Skip to content

Add actor state TTL support.#1060

Closed
artursouza wants to merge 27 commits intodapr:masterfrom
artursouza:actor_ttl
Closed

Add actor state TTL support.#1060
artursouza wants to merge 27 commits intodapr:masterfrom
artursouza:actor_ttl

Conversation

@artursouza
Copy link
Contributor

@artursouza artursouza commented Jun 26, 2024

Description

Add actor state TTL support.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #849

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artursouza artursouza requested review from a team as code owners June 26, 2024 14:48
@artursouza artursouza marked this pull request as draft June 26, 2024 14:48
artursouza
artursouza commented Jun 26, 2024
View reviewed changes
artursouza
artursouza commented Jun 26, 2024
View reviewed changes
artursouza
artursouza commented Jun 26, 2024
View reviewed changes
@artursouza
Add actor state TTL support.
d82b0c1 
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
@artursouza
Scope actorstatestore to actor ITs only.
6f382ff 
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
@artursouza artursouza marked this pull request as ready for review June 26, 2024 18:07
artursouza and others added 2 commits June 26, 2024 11:13
cicoyle
cicoyle previously approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

artur-ciocanu
artur-ciocanu previously approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artursouza looks great!

I have a more general design question related to ActorState. ActorState uses a generic type, however in ActorStateManager it is used without generic type. I am wondering if we should try to enforce generic type usage across other classes like: AbstractActor, StateChangeMetadata, ActorStateOperation, etc to ensure a stronger type safety.

What are your thoughts?

@artursouza
Copy link
Contributor Author

artursouza commented Jun 27, 2024

@artursouza looks great!

I have a more general design question related to ActorState. ActorState uses a generic type, however in ActorStateManager it is used without generic type. I am wondering if we should try to enforce generic type usage across other classes like: AbstractActor, StateChangeMetadata, ActorStateOperation, etc to ensure a stronger type safety.

What are your thoughts?

Let me give it a try. These are not exposed to the user and are for internal use only. There might be a reason I did not propagate the generic type everywhere, but I don't remember now. Again, let me revisit this.

@mikeee mikeee mentioned this pull request Jun 28, 2024
Closed
@cicoyle cicoyle mentioned this pull request Jul 25, 2024
Open
5 tasks
@artursouza
Merge branch 'master' into actor_ttl
23ab28f 
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
artursouza and others added 2 commits November 15, 2024 09:46
@artursouza
Merge branch 'master' into actor_ttl
54343d1 
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
@artursouza
Address comments
8dbf275 
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
@hhunter-ms hhunter-ms mentioned this pull request Dec 2, 2024
Open
@artursouza
Copy link
Contributor Author

artursouza commented Dec 3, 2024

@artursouza looks great!
I have a more general design question related to ActorState. ActorState uses a generic type, however in ActorStateManager it is used without generic type. I am wondering if we should try to enforce generic type usage across other classes like: AbstractActor, StateChangeMetadata, ActorStateOperation, etc to ensure a stronger type safety.
What are your thoughts?

Let me give it a try. These are not exposed to the user and are for internal use only. There might be a reason I did not propagate the generic type everywhere, but I don't remember now. Again, let me revisit this.

See my reply. This is not needed because it is used for serialization and does not interface with the user's API.

@artur-ciocanu
Update configuration.yaml
39340c4 
Add new line to make GitHub happy
artur-ciocanu
artur-ciocanu previously approved these changes Mar 2, 2025
View reviewed changes
Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really, really good!

@artur-ciocanu
Update ActorStateIT.java
6694e2c 
Ensure the test compiles and uses the right DaprRun instance.
@artur-ciocanu
Update ActorStateIT.java
d9e8445 
Fix compilation errors
@artur-ciocanu artur-ciocanu self-requested a review March 3, 2025 01:25
artur-ciocanu
artur-ciocanu previously approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@artur-ciocanu
Update ActorStateIT.java
4152393 
Fix compilation errors
artur-ciocanu
artur-ciocanu previously approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving one more time for CI

@artur-ciocanu
Update ActorStateIT.java
4b5afc2 
Increase sleep for actor activation
@artur-ciocanu
Copy link
Contributor

artur-ciocanu commented Mar 4, 2025

@artursouza if you'll have some time could you please check why the tests are failing. I have tried to fix the compilation issues, however I am not sure why the IT is failing.

Thank you!

@salaboy
Copy link
Collaborator

salaboy commented Mar 19, 2025

@cicoyle it might be good if you take this issue, as you were involved.. IMHO the best way to proceed is to create a new PR using the changes from this PR, so we have no DCO issues and then make sure that the tests are green.

@salaboy salaboy modified the milestones: v1.14, v1.15 Mar 19, 2025
@cicoyle cicoyle self-assigned this Mar 26, 2025
@cicoyle cicoyle mentioned this pull request Apr 1, 2025
Open
@cicoyle cicoyle mentioned this pull request May 8, 2025
Draft
@cicoyle
Copy link
Contributor

cicoyle commented May 8, 2025

Closing this PR to proceed with this PR

@cicoyle cicoyle closed this May 8, 2025
@siri-varma siri-varma modified the milestones: v1.15, v1.16 Aug 20, 2025
@mikeee mikeee removed this from the v1.16 milestone Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artur-ciocanu artur-ciocanu artur-ciocanu left review comments

@cicoyle cicoyle Awaiting requested review from cicoyle

Assignees

@cicoyle cicoyle

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FEATURE PREVIEW: Add Actor State TTL support

7 participants

@artursouza @artur-ciocanu @salaboy @cicoyle @siri-varma @mikeee @dapr-bot